Makefile: remove check-migrations

Closes: getodk#1397
alxndrsn · Feb 11, 2025 · 4920acf · 4920acf
1 parent 4af4f33
commit 4920acf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 33 deletions.
diff --git a/Makefile b/Makefile
@@ -72,16 +72,12 @@ fake-s3-server-persistent:
 migrations: node_version
 	node lib/bin/run-migrations.js
 
-.PHONY: check-migrations
-check-migrations: node_version
-	node lib/bin/check-migrations.js
-
 
 ################################################################################
 # RUN SERVER
 
 .PHONY: base
-base: node_modules node_version migrations check-migrations
+base: node_modules node_version migrations
 
 .PHONY: dev
 dev: base

diff --git a/lib/bin/check-migrations.js b/lib/bin/check-migrations.js
diff --git a/lib/model/knex-migrator.js b/lib/model/knex-migrator.js
@@ -25,13 +25,5 @@ const withKnex = (config) => (mutator) => {
 // Given a database, initiates migrations on it.
 const migrate = (db) => db.migrate.latest({ directory: `${__dirname}/migrations` });
 
-// Checks for pending migrations and returns an exit code of 1 if any are
-// still pending/unapplied (e.g. automatically running migrations just failed).
-const checkMigrations = (db) => db.migrate.list({ directory: `${__dirname}/migrations` })
-  .then((res) => {
-    if (res[1].length > 0)
-      process.exitCode = 1;
-  });
-
-module.exports = { checkMigrations, knexConnect, withKnex, migrate };
+module.exports = { knexConnect, withKnex, migrate };