Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support avif image file inline displays #124

Open
k4r4b3y opened this issue Dec 14, 2024 · 4 comments
Open

Support avif image file inline displays #124

k4r4b3y opened this issue Dec 14, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@k4r4b3y
Copy link

k4r4b3y commented Dec 14, 2024

First let me say that Orgro is hands-down the best mobile app for reading the org files of mine. Thanks for creating and maintaining this.

Now, onto the feature request:

I use .avif format for my image files. In debian 12, I simply use convert image.jpg image.avif to create these. Avif files have better compression and therefore take much less space than the their jpg counterparts. Currently, my avif files linked inside my org mode documents do not get rendered inside Orgro. Would you consider adding support for rendering .avif files as inline images?

@amake amake changed the title Feature request: Support avif image file inline displays Support avif image file inline displays Dec 14, 2024
@amake amake added the enhancement New feature or request label Dec 14, 2024
@amake
Copy link
Owner

amake commented Dec 14, 2024

Thanks for the kind words.

Support for more formats is good; my main concern is not bloating the app install size.

Relevant info:

@amake
Copy link
Owner

amake commented Dec 14, 2024

I have basically an allowlist of image file extensions. I will add .avif to the list, but actually displaying the image will depend on whether your device's OS supports the AVIF format.

This will be available in v1.50.0, ready for testing soon:

amake added a commit that referenced this issue Dec 14, 2024
@k4r4b3y
Copy link
Author

k4r4b3y commented Dec 14, 2024

I will add .avif to the list

Thank you!

but actually displaying the image will depend on whether your device's OS supports the AVIF format.

I am on latest GrapheneOS release. Once the Orgro update hits fdroid, I will test whether my OS is able to display inline .avif or not.

@amake
Copy link
Owner

amake commented Dec 15, 2024

It can take weeks to make it into F-Droid, so if you are in any sort of hurry I would suggest installing from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants