Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CTRL+W for closing tabs. #19

Open
githubenjoyer opened this issue Nov 14, 2023 · 2 comments
Open

Implement CTRL+W for closing tabs. #19

githubenjoyer opened this issue Nov 14, 2023 · 2 comments

Comments

@githubenjoyer
Copy link

Loving the extension so far but the most I am missing right now from Gesture Improvements is it used Ctrl+W for closing tabs. And I just got so used to that while browsing or any app with tabs. And it also works as closing the window most of the time even if the app doesn't have any tabs to speak of. Thank you for your efforts and keep doing a great job!

@amarullz
Copy link
Owner

For this, I will add custom keyboard shortcuts, so not only for Ctrl+w but for other usage. I still learn how to add it in pref.

Also I try to add window specific settings (at least for pinch gestures)

@dasGesundeplus
Copy link

Great to hear.
I actually added an option in prefs.js and copied the the close-window-functionality minus the window disappearing at touchpad release to implement this function for myself, because i really missed this part of my touchpad workflow.

The following is just a suggestion, but I think it would make sense to have Ctrl+W as a kind of special case of the window close functionality, because in many programs, you are committing an action that is not easily reversible.
To signify this, the red closing animation makes a lot of sense to me.
Maybe the animation of close window and close document can be differentiated by choosing a smaller pinch-end-state (the point at which the action is executed) or by using an accelerated scale-down to the final size.

That being said, custom keyboard shortcuts would be a welcome addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants