Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Expose Property class for modification #114

Open
jpasquers opened this issue Aug 17, 2020 · 0 comments · May be fixed by #115
Open

Expose Property class for modification #114

jpasquers opened this issue Aug 17, 2020 · 0 comments · May be fixed by #115

Comments

@jpasquers
Copy link

As mentioned in one of the first responses to #11 :

"I would be more inclined to expose the Property tree used to construct the query string in the requestEntity"

We have had the need to dynamically modify the query (reduce query/response size without creating POJOs for each use case), and my idea was to 'post process' the Property object after the RequestEntity was built, exactly like you mentioned. At that point, we could remove/modify any of the children as needed. To do this at the very least we would need the Property class visible. In addition, I would prefer to not have to use reflection, and I don't really see a strong reason why the property field shouldn't be visible.

If this is something you're open to, let me know if you would like me to open a PR (I'm not sure if you had a particular approach you wanted to take).

jpasquers pushed a commit to jpasquers/nodes that referenced this issue Aug 17, 2020
Expose both the Property class and the property field within the RequestEntity.

Closes americanexpress#114
@jpasquers jpasquers linked a pull request Aug 17, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant