Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to draw 3d arrows #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add the possibility to draw 3d arrows #86

wants to merge 2 commits into from

Conversation

GiulioRomualdi
Copy link
Member

If a signal has 6 channels it is now possible to draw a 3d arrow. The first three elements are considered as the origin of the arrow while the other three as vector components.

This is an example

Screencast.from.26-09-2024.17.23.33.webm

This feature came out after a discussion with @davidegorbani and @Gianlucamilani

@GiulioRomualdi GiulioRomualdi added the enhancement New feature or request label Sep 26, 2024
@GiulioRomualdi GiulioRomualdi self-assigned this Sep 26, 2024
@traversaro
Copy link
Contributor

traversaro commented Sep 26, 2024

Cool! In the logger how is the px py and pz of the force logged?

@S-Dafarra
Copy link
Member

Cool! The only open point I have is regarding the normalization. Right now it is normalized using the maximum (if I got it right), and it makes sense. Nonetheless, I believe there could be two cases in which we could have issues:

  1. real-time logging, as the maximum might not be known beforehand
  2. lack of comparison between arrows; if I have two arrows with different maximums, they might appear equal even if they are not.

Would it make sense to apply a constant scaling instead?

@GiulioRomualdi
Copy link
Member Author

For real-time, I have to check how to handle it (maybe a constant scaling would be beneficial). Here, the maximum is computed as the maximum of all the selected arrows. So, the proportion is still considered

@GiulioRomualdi
Copy link
Member Author

Cool! In the logger how is the px py and pz of the force logged?

I modified the walking to test it so I logged the position of lsole and r sole

@traversaro
Copy link
Contributor

Cool! In the logger how is the px py and pz of the force logged?

I modified the walking to test it so I logged the position of lsole and r sole

And the same piece of code is also logging the base pose, so the two are coherent?

@GiulioRomualdi
Copy link
Member Author

Cool! In the logger how is the px py and pz of the force logged?

I modified the walking to test it so I logged the position of lsole and r sole

And the same piece of code is also logging the base pose, so the two are coherent?

Yep, that one was already available

@DanielePucci
Copy link
Member

Fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants