-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to draw 3d arrows #86
base: main
Are you sure you want to change the base?
Conversation
Cool! In the logger how is the |
Cool! The only open point I have is regarding the normalization. Right now it is normalized using the maximum (if I got it right), and it makes sense. Nonetheless, I believe there could be two cases in which we could have issues:
Would it make sense to apply a constant scaling instead? |
For real-time, I have to check how to handle it (maybe a constant scaling would be beneficial). Here, the maximum is computed as the maximum of all the selected arrows. So, the proportion is still considered |
I modified the walking to test it so I logged the position of lsole and r sole |
And the same piece of code is also logging the base pose, so the two are coherent? |
Yep, that one was already available |
Fantastic |
If a signal has 6 channels it is now possible to draw a 3d arrow. The first three elements are considered as the origin of the arrow while the other three as vector components.
This is an example
Screencast.from.26-09-2024.17.23.33.webm
This feature came out after a discussion with @davidegorbani and @Gianlucamilani