Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterLogHandler cannot accept all log records #18

Open
wtsergo opened this issue May 29, 2024 · 0 comments
Open

ClusterLogHandler cannot accept all log records #18

wtsergo opened this issue May 29, 2024 · 0 comments

Comments

@wtsergo
Copy link

wtsergo commented May 29, 2024

ClusterLogHandler cannot accept all log records.
e.g. in \Amp\Http\Server\Driver\Internal\AbstractHttpDriver::handleInternalServerError
you have

$this->logger->error(
  "...",
  [
    ...
    'method' => $request,
    ...
  ]
);

Then ClusterLogHandler cannot send such error context via channel because $request have closures in nested properties.
Maybe need to add some kind of filter there? e.g. skip unserializable items?

I can contribute on fix for that.
Just let me know how do you think such problem should be handled.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant