From 1a72e0f6aa2cb5960327da5ebbd2cd6f63a10d1b Mon Sep 17 00:00:00 2001 From: "izaaz.yunus" Date: Wed, 21 Aug 2024 16:11:54 -0700 Subject: [PATCH 1/2] fix: Add exception message in callback message --- src/main/java/com/amplitude/HttpTransport.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/amplitude/HttpTransport.java b/src/main/java/com/amplitude/HttpTransport.java index cc3d07a..12f5eb6 100644 --- a/src/main/java/com/amplitude/HttpTransport.java +++ b/src/main/java/com/amplitude/HttpTransport.java @@ -434,6 +434,7 @@ public void run() { callbackMessage = "Unknown response status."; } } catch (Exception exception) { + callbackMessage = "Error sending events due to the exception: " + exception.getMessage(); logger.error("Flush Thread Error", Utils.getStackTrace(exception)); logger.error("Error event payload", events.toString()); } finally { From 48aec4b5d9802aed8403738599eae5af87322a84 Mon Sep 17 00:00:00 2001 From: "izaaz.yunus" Date: Wed, 21 Aug 2024 16:22:47 -0700 Subject: [PATCH 2/2] chore: Fix tests --- src/main/java/com/amplitude/HttpTransport.java | 3 ++- src/test/java/com/amplitude/HttpTransportTest.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/amplitude/HttpTransport.java b/src/main/java/com/amplitude/HttpTransport.java index 12f5eb6..127f8ec 100644 --- a/src/main/java/com/amplitude/HttpTransport.java +++ b/src/main/java/com/amplitude/HttpTransport.java @@ -434,7 +434,8 @@ public void run() { callbackMessage = "Unknown response status."; } } catch (Exception exception) { - callbackMessage = "Error sending events due to the exception: " + exception.getMessage(); + callbackMessage = + "Error sending events due to the exception: " + exception + ". Message: " + exception.getMessage(); logger.error("Flush Thread Error", Utils.getStackTrace(exception)); logger.error("Error event payload", events.toString()); } finally { diff --git a/src/test/java/com/amplitude/HttpTransportTest.java b/src/test/java/com/amplitude/HttpTransportTest.java index feb7451..b93958b 100644 --- a/src/test/java/com/amplitude/HttpTransportTest.java +++ b/src/test/java/com/amplitude/HttpTransportTest.java @@ -435,7 +435,7 @@ public void testThreadTimeoutCallback() @Override public void onLogEventServerResponse(Event event, int status, String message) { resultMap.put(event, status); - assertEquals("Error send events", message); + assertEquals("Error sending events due to the exception: java.util.concurrent.TimeoutException. Message: null", message); latch.countDown(); } };