Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentWillReceiveProps for react-amp-document will be removed in React 17 #122

Open
kevinkassimo opened this issue Aug 31, 2018 · 0 comments
Open

componentWillReceiveProps for react-amp-document will be removed in React 17 #122

kevinkassimo opened this issue Aug 31, 2018 · 0 comments

Comments

@kevinkassimo
Copy link
Member

Per https://reactjs.org/blog/2018/03/29/react-v-16-3.html

New lifecycle hook is getDerivedStateFromProps (which returns state change), or we can simply switch to componentDidUpdate (store url and only fetchDocument when prop url changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinkassimo