Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent connection between a discord voice chat and an in-game group #80

Open
AdalynBlack opened this issue Dec 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@AdalynBlack
Copy link

Is your feature request related to a problem? Please describe.
When I initially saw the mod, I was expecting that it would have the bot automatically join the specified group, and forward Discord audio to SVC, and SVC audio to discord. That way, people who aren't currently in the game can still join the group and talk with people without having to awkwardly make a Discord call at the same time

Describe the solution you'd like
I'd simply like a way to have the bot automatically create a room with a specified name and configuration, which is bridged to a discord voice chat, that way people can use the mod while offline

Describe alternatives you've considered
There are no other mods I can see that do this. The only alternative I have would be to fork the mod, implement the feature myself, and probably PR it back in

@amsam0 amsam0 added the enhancement New feature or request label Dec 22, 2024
@amsam0 amsam0 changed the title [Feature Request] Permanent connection between a discord voice chat and an in-game group Permanent connection between a discord voice chat and an in-game group Dec 22, 2024
@amsam0
Copy link
Owner

amsam0 commented Dec 22, 2024

If you haven’t read the project status update, please read it. The TLDR is that I won’t be introducing any new features myself. That being said, PRs are 100% welcome.

As for the feasibility of this, there are a few barriers that would need to be overcome:

  1. Simply "creating a group" and bridging a bot to it is not as simple as it may sound. The main issue with this is recording and sending back audio. To maintain proper compatibility with SVC features and other addons, a fake player of sorts would need to be added to the group. This would most likely be very difficult, and would cause all kinds of issues.
    • An alternative is to record all MicrophonePackets from the players in the group and play audio with a static audio channel, but this would cause issues with SVC feature compatibility and other addons.
  2. Recording audio from multiple users in one Discord call is much more complicated than recording audio from a single user, and this is why the addon currently breaks when more than one person talks in the same call. While this was supported by the old JDA backend, the new rust backend would require us to implement this ourselves.

Not to mention keeping the existing functionality of the addon. Exposing this in a user friendly way may be difficult and this might be best as a separate addon (although, as I've said previously, I am 100% open to PRs).

I think this has been suggested before; I don't see what the point of all this would be when you can just join a normal discord call that would act the exact same as the group system, with the only downside being it's not integrated into Minecraft.

@amsam0 amsam0 added the wontfix This will not be worked on label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants