You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off I'd like to say thank you for writing such an excellent logger! I'm interested in trying this and was thinking of running an InfluxDB instances alongside my existing Prometheus DB, but I thought it might be more interesting instead to fork this and expand on the sampling_loop to support Prometheus as well as InfluxDB.
Time permitting and if I have any success getting this to work cleanly, would you be open to me contributing a PR back for review? I want to gauge your interest first before I submit anything back to you without context.
Either way, thank you again for writing this.
The text was updated successfully, but these errors were encountered:
Definitely sounds useful!
Id be happy to accept a PR for Prometheus support (or advertise a link to your fork). When I started this project, I remember intentionally choosing InfluxDB over Prometheus, but I forget the exact reason. Having a parallel implementation that uses Prometheus would surely be useful to the solar community!
Hey again. I have made significant updates to the repository including:
Adding linting and formatting checks and auto-corrections
Unit testing plus code coverage metrics gathering
Docker builds integrated with Github Actions
Fixed timestamp issues (now uses timestamps returned by Envoy adjusted to the correct local timezone)
Fixed login token and sessionid issues by refactoring functional code into classes
And finally...added support for Prometheus
Since the changes are so vast I think it might be easier to submit upstream to your repository if we discussed these changes. Would you be open to discussing this?
In any case thank you again for creating this project. I've had a lot of fun adapting this to Prometheus and I've learned a lot about both InfluxDB and the prometheus_client in this process.
First off I'd like to say thank you for writing such an excellent logger! I'm interested in trying this and was thinking of running an InfluxDB instances alongside my existing Prometheus DB, but I thought it might be more interesting instead to fork this and expand on the sampling_loop to support Prometheus as well as InfluxDB.
Time permitting and if I have any success getting this to work cleanly, would you be open to me contributing a PR back for review? I want to gauge your interest first before I submit anything back to you without context.
Either way, thank you again for writing this.
The text was updated successfully, but these errors were encountered: