Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async callbacks for long-running commands #33

Open
philippjfr opened this issue Aug 21, 2019 · 1 comment
Open

Add async callbacks for long-running commands #33

philippjfr opened this issue Aug 21, 2019 · 1 comment

Comments

@philippjfr
Copy link
Collaborator

When starting, stopping or restarting a session or deployment you currently have the option to wait. However starting a deployment can take a couple of minutes and in certain applications (e.g. a dashboard) you don't want to block that long. It would therefore be nice if you could schedule an async callback which is called when the task completes.

In my particular use case this would allow me to show notifications in the dashboard when a task completes.

@mcg1969
Copy link
Collaborator

mcg1969 commented Sep 15, 2019

Sorry I haven't responded to this yet. I do think it's a good idea. Let's brainstorm on a good way to implement this. Note that I tried to implement a single "_wait" method and found that I could not reliably do so; there are differences between the different events that one should wait for. But if we do this, we can certainly implement a single approach to specify callbacks, even if the internal wait loop for each is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants