From 43777e1c1d1d76bebbafcb9eacec50e35cdac983 Mon Sep 17 00:00:00 2001
From: Enzo <enzo.baldisserri@outlook.fr>
Date: Wed, 15 Jan 2025 22:28:45 +0100
Subject: [PATCH] test(books): rework `books_test.exs` a little bit

- remove non-necessary module attribute
- remove non-necessary context function
---
 apps/app/test/app/books_test.exs | 38 ++++++++++++++++----------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/apps/app/test/app/books_test.exs b/apps/app/test/app/books_test.exs
index a9f4874b..4db31aa0 100644
--- a/apps/app/test/app/books_test.exs
+++ b/apps/app/test/app/books_test.exs
@@ -9,12 +9,15 @@ defmodule App.BooksTest do
   alias App.Books.Book
   alias App.Books.Members
 
-  @valid_book_name "A valid book name !"
-
   ## Database getters
 
   describe "get_book_of_user/2" do
-    setup :book_with_creator_context
+    setup do
+      book = book_fixture()
+      user = user_fixture()
+      _member = book_member_fixture(book, user_id: user.id, role: :creator)
+      %{book: book, user: user}
+    end
 
     test "returns the book", %{book: book, user: user} do
       user_book = Books.get_book_of_user(book.id, user)
@@ -38,7 +41,12 @@ defmodule App.BooksTest do
   end
 
   describe "get_book_of_user!/2" do
-    setup :book_with_creator_context
+    setup do
+      book = book_fixture()
+      user = user_fixture()
+      _member = book_member_fixture(book, user_id: user.id, role: :creator)
+      %{book: book, user: user}
+    end
 
     test "returns the book", %{book: book, user: user} do
       user_book = Books.get_book_of_user!(book.id, user)
@@ -195,7 +203,7 @@ defmodule App.BooksTest do
         book_attributes(nickname: "Creator nickname")
         |> Books.create_book(user)
 
-      assert book.name == @valid_book_name
+      assert book.name == "A valid book name !"
 
       assert member = Members.get_membership(book, user)
       assert member.role == :creator
@@ -222,7 +230,9 @@ defmodule App.BooksTest do
   ## Name update
 
   describe "update_book_name/2" do
-    setup :book_with_creator_context
+    setup do
+      %{book: book_fixture()}
+    end
 
     test "updates the name of the book", %{book: book} do
       assert {:ok, updated} =
@@ -253,7 +263,9 @@ defmodule App.BooksTest do
   ## Deletion
 
   describe "delete_book!/2" do
-    setup :book_with_creator_context
+    setup do
+      %{book: book_fixture()}
+    end
 
     test "deletes the book", %{book: book} do
       deleted = Books.delete_book!(book)
@@ -355,16 +367,4 @@ defmodule App.BooksTest do
       assert Books.get_book_by_invitation_token("foo") == nil
     end
   end
-
-  defp book_with_creator_context(_context) do
-    book = book_fixture()
-    user = user_fixture()
-    member = book_member_fixture(book, user_id: user.id, role: :creator)
-
-    %{
-      book: book,
-      user: user,
-      member: member
-    }
-  end
 end