Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x11vnc #171

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Fix x11vnc #171

merged 3 commits into from
Sep 3, 2024

Conversation

mlradu
Copy link
Collaborator

@mlradu mlradu commented Sep 2, 2024

Pull Request Description

Fix X11VNC so that it works on systems that don't have video output. From now on the user won't need to run 'enable_dummy_display.sh', this will be done automatically.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have built Kuiper Linux image with the changes
  • I have tested new image in hardware, on relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc)

Change X server settings to allow any user to start it. This setting is necessary when using X11VNC with a dummy display.

Signed-off-by: mlradu <[email protected]>
xserver.service: oneshot service that runs adi-xserver.sh
adi-xserver.sh: script that configures the xserver for systems without video output
run.sh: copy xserver.service and adi-xserver.sh in the rootfs, enable xserver.service; change the xserver settings so that it can be started by any user

Signed-off-by: mlradu <[email protected]>
Now that the xserver.service handles the setup for systems that don't have video output, this feature is no longer necessary.

Signed-off-by: mlradu <[email protected]>
@mlradu
Copy link
Collaborator Author

mlradu commented Sep 2, 2024

v2:

  • removed 'if' statement from adi-xserver.sh

@mlradu mlradu merged commit 1b0b03d into staging/kuiper2.0 Sep 3, 2024
5 checks passed
@mlradu mlradu deleted the fix_x11vnc branch September 3, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants