-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD7944: Add support for AD7944/85/86 devices #635
base: main
Are you sure you want to change the base?
Conversation
@tfcollins I think this is mostly ready to squash, do any extra pre-commit cleanups on, etc. (once I get the ad7944 and ad7986 emulation files updated), but I have a question about tests: This device's data type and Given that the non-offload version also requires a hrtimer trigger to be configured on the host system, it may not be reasonable to include support for that mode. I'm still experimenting... Is this a problem from a pyadi-iio perspective, if it's documented? |
5fd6ec3
to
fc24604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine. Just need to fix lint errors
fc24604
to
11a35f7
Compare
Updated! |
Accidentally hit close. Should be ready to go now. |
- Add adi/ad7944.py module - Add ad7944 to index.rst - Add ad7944/85/86 to supported_parts.md - Add ad7944 doc stub - Add test/ad7944/85/86.py test, xml file - Add ad7944/85/86 to hardware_map.xml Signed-off-by: Florian Sylvestre <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
11a35f7
to
0928c6f
Compare
@tfcollins FYI the XML was updated, but I don't have merge permission. |
Description
This is the (final) PR for supporting the AD7944, AD7985, and AD7986 devices in pyadi-iio. It features a somewhat new approach to testing the
sampling_frequency
attribute and some variable logic depending on whether or not SPI offload is enabled in the driver.Note that it supersedes the work done in #562.
As of right now, new emulation files still need to be added for the AD7944 and AD7986, so it's marked as a draft.
Type of change
Please delete options that are not relevant.
How has this been tested?
Test Configuration:
Documentation
Documentation is included to reflect the new devices and their functionality.
Checklist: