Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scopy: SPI generating bad patterns #1452

Closed
lysynski opened this issue Aug 24, 2023 · 6 comments
Closed

Scopy: SPI generating bad patterns #1452

lysynski opened this issue Aug 24, 2023 · 6 comments
Labels
bug m2k bugs related to the M2kPlugin in Scopy v2

Comments

@lysynski
Copy link

Environment:

  • OS: Windows
  • FW 0.29
  • SW Version v1.4.1

Describe the bug
SPI pattern generator creates bad messages when CPHA is set to 0. Bad data and missing final clock pulse.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Pattern Generator
  2. create a group with 3 channels (bits); CLK, MOSI, CS for SPI pattern
  3. set CPOL = 0, CPHA = 0, CS Polarity = 0, MSB First enabled, 2 Bytes per frame, data = 0500
  4. See error (screenshot CAP1)
  5. See analyzer capture - decoded data bad
  6. set data=07FF
  7. See error (screenshot CAP2)

Expected behavior
correct SPI pattern for setting applied

Screenshots
Scopy SPI Bug CAP1
SDS00018 Analyzer CAP
Scopy SPI Bug CAP2

@lysynski lysynski added the bug label Aug 24, 2023
@AlexandraTrifan
Copy link
Contributor

AlexandraTrifan commented Dec 11, 2024

Hi!

The initial release candidate for the new Scopy v2.0.0 is now available in the official releases page: https://github.com/analogdevicesinc/scopy/releases/tag/v2.0.0-beta-rc1. This candidate includes a lot of new features in Scopy while bringing multiple bug fixes for the ADALM2000 plugin and underlying libm2k library.

The pull request regarding this issue is: #1496
Could you give this version a try and reopen the issue if the bug still appears?

Thank you!

@AlexandraTrifan AlexandraTrifan added the m2k bugs related to the M2kPlugin in Scopy v2 label Dec 11, 2024
@lysynski
Copy link
Author

lysynski commented Dec 17, 2024

Hi

Thanks for the link. I downloaded the MacOS version, I see there’s more than a DMG in the zip file but there’s not instructions for installation. Should I follow typical installation and just copy Scopy from the DMG to my applications folder or is there more that needs to be done?

Thanks
Boris

@adisuciu
Copy link
Contributor

Yes, typical installation of a DMG file. The rest of the files are auxiliary to the build process, used mainly for debugging. We'll clean them in a future version.

@lysynski
Copy link
Author

I tried the new release... you need more testing.
I can enable channels and group them but the visual for this needs to be more obvious as the white frame around the channels isn't obvious and it's difficult to see that they're part of the group. Once grouped, I switch the pattern to SPI. It's not obvious which channel is what signal. I enabled ch0-2, ch0 became clk, ch1 data, ch2 enable; there's no indicator to show this and I have no control to change it. Changing the SPI parameters (buttons) doesn't update the generated pattern shown on screen even if I run the pattern generator. Output is also unaffected. It only changes if I modify one of the data fields.

@AlexandraTrifan
Copy link
Contributor

From a UI/UX point of view, the M2K plugin needs a rework. We've been focused on the new Scopy infrastructure in order to provide support for other boards. This rework of the M2k plugin would include a different way to display channel information for grouped channels, information about their roles in the decoder - maybe similar to the one found in the Logic Analyzer.
For now, the channel order in the decoder can be changed by grabbing the Burger Menu Button for each channel in the Decoder Menu (right side menu) and dragging it above or below other channels.

As for the last remark, the buttons don't apply indeed. It seems to be a side effect of a major change done in the last month. I've added a fix for this (#1867) and it will be included in the next release candidate.

Thank you!

@lysynski
Copy link
Author

I tired moving the signals with the burger menu. After a couple moves they lose their positioning in the list, shifted down with nothing above. I tried to put them back in order and the app crashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug m2k bugs related to the M2kPlugin in Scopy v2
Projects
None yet
Development

No branches or pull requests

3 participants