Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mermaid in marddown file not rendered #846

Open
2 tasks
DrMabuse23 opened this issue Jan 10, 2024 · 4 comments
Open
2 tasks

mermaid in marddown file not rendered #846

DrMabuse23 opened this issue Jan 10, 2024 · 4 comments
Labels
accepting PRs bug Something isn't working

Comments

@DrMabuse23
Copy link

Please provide the environment you discovered this bug in.

node --version
v18.18.2

Which area/package is the issue in?

create-analog

Description

I created up a repository for you just do

npm i
npx nx run analog-app:serve

please see discord discussion

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@DrMabuse23 DrMabuse23 added the bug Something isn't working label Jan 10, 2024
@d-koppenhagen
Copy link
Contributor

d-koppenhagen commented Jan 17, 2024

@DrMabuse23 the referenced repo seems not to be public, or even exist.

have configured to use mermaid as described in the docs?

withMarkdownRenderer({
  loadMermaid: () => import('mermaid'),
});

@DrMabuse23
Copy link
Author

Sorry I changed the
Visibility

@brandonroberts
Copy link
Member

It is a bug because the MarkdownRouteComponent does not load the necessary mermaid functionality

https://github.com/analogjs/analog/blob/main/packages/content/src/lib/markdown-route.component.ts

The AnalogMarkdownComponent does.

https://github.com/analogjs/analog/blob/main/packages/content/src/lib/markdown.component.ts

@rlmestre
Copy link
Contributor

Is the separate route component necessary at all? They are the same except the mermaid functionality 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting PRs bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants