-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive plots #15
Comments
dygraphs is the first thing that comes to my mind. |
Thanks @joshuaulrich |
animint is best when you have multiple plots and you want to click one of them to update what is shown in the others. maybe we could use it to explore the larger data set (time and memory measurements across several commits, for several different tests) |
Yeah, makes sense @tdhock |
Interactive plots will be most useful when working with travis. Thus, it didn't make sense to mess much with the existing plotting functions. animint seems to have issues dealing with the existing facets and vertical alignment of x-axis text labels. But it can be dealt with. But one issue is the way plots are aligned next to one another (in this case, 3 at a time). This cuts out the title text and makes it messy in general. Is there a way to make it so that animint plots are rendered one after another in a top-down manner (vertically)? |
Hey @analyticalmonk did you try |
another option is to use |
I had tried using An animint for the tests using What would be better? To work with facets only and try other workarounds such as shortening label length, or using color legends. Or using the method employing showSelected. |
for now I think facets are better. (but we have another GSOC student working @faizan-khan-iit on getting animint's axes to update after changing the selection, so hopefully that could be an option by the end of summer) for the facets you can either try to shorten the facet label or give the facets more space with |
also you may consider just copying the code used by codespeed and asv. Do you think it would be possible to output some data files from R and have those files be read directly by the codespeed/asv viz tools? |
- Change made in R/plot_metrics.R - Example: Label for a test named "check now if 12345" will appear as "che...345", i.e., first 3 characters and last 3 characters separated by an ellipsis. Change as discussed in Issue #15
- animint contains embedded github links - plot contains facet with shortened labels animint as discussed in #15
The Rperform gh-page now contains an updated version of the animint. I wanted to see how it works on a random package from the wild so used it on namedCapture; seems to work fine.
@tdhock @joshuaulrich |
There were a couple of issues I ran into:
Also, I will look into the possibility of using the asv viz tools. codespeed won't be an option since it works in tandem with Django but I will look into it again just to be sure. |
Hey Akash that looks good with the links to the namedCapture commits. Also shortening the facet labels seems like a reasonable strategy (for now). Eventually I think it would be better to add a About the href/tooltip problem, please post a simple example as an issue https://github.com/tdhock/animint/issues/new and tag @faizan-khan-iit who may be able to work on that in the next few weeks (Faizan, please add Akash's example as a test case -- seems like this should be an easy fix, and it would be a good introduction for you to the JS code). Akash the newest version of animint's master branch is now working with ggplot2 >= 2.0 so you should try installing that. |
Akash, sorry for the confusion. Right now you have a single |
If that is still confusing, can you please post the data of test results and I will write some example ggplot/animint code for you. |
I still don't get it entirely but I have tried making a rough viz from what I understood. It's hosted here. I have used mean as a summary statistic for the sake convenience here. The data I am working with for this is in the following format:
I have omitted the sha and datetime columns Code I wrote to obtain the above:
|
that looks like a step in the right direction. now I would suggest changing the y axis variable on the details plot to a normalized variable, so you can use up all the space in the plot. e.g. also can you change the x axis of the details plot to another quantitative metric? For example you could compute a p-value using a one-sided, unpaired t-test (test if mean of the master branch is less than the mean of each commit from the other branch) and then plot the minimum p-value over all commits. I would also suggest adding data for all test files, and then you can have three plots: one to select the test file, one to select the particular test block, and finally the details for the selected tests. In that case you could add another text label as a title for the currently selected test file. |
hey @analyticalmonk, thanks to @faizan-khan-iit who worked on animint in GSOC2016, we now have axis updates, which would be very useful for your performance data viz. You just need to add the |
@tdhock Sounds good. Will do the changes. |
@tdhock Had been extremely busy over the last few weeks. Will be making working and making a few changes to Rperform over the next few days. Guess will finally make the interactive plots work with the updates to animint. |
great, if you have any issues with animint, don't hesitate to get in touch with me or @faizan-khan-iit |
Introduce interactivity in the performance plots being rendered. Similar to the ones returned by
asv (example) and codespeed (example).
@tdhock animint could be used for something like this, right? Or are there any other alternatives off the top of your mind?
The text was updated successfully, but these errors were encountered: