Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIComparer not showing changes to interfaces #69

Open
bording opened this issue May 20, 2016 · 5 comments
Open

APIComparer not showing changes to interfaces #69

bording opened this issue May 20, 2016 · 5 comments

Comments

@bording
Copy link

bording commented May 20, 2016

While comparing the changes in the latest RabbitMQ client, it appears that APIComparer is missing some of the changes that were made:

http://apicomparer.particular.net/compare/RabbitMQ.Client/3.6.1...3.6.2

Here is the comparison of what all was changed between 3.6.1 and 3.6.2:

rabbitmq/rabbitmq-dotnet-client@rabbitmq_v3_6_1...rabbitmq_v3_6_2

For example, there was a new property added to IConnection but that isn't showing up in the comparison. Since changes to an interface are always going to break implementors, I expected to see it listed.

@andreasohlund
Copy link
Owner

We haven't been showing additions since we always considered them non breaking changes. But interfaces is interesting since additions would be be non breaking for consumers but breaking for implementors. @ParticularLabs/apicomparer thoughts?

@bording
Copy link
Author

bording commented May 20, 2016

Given that one scenario around public interfaces is allowing you to provide your own implementation of the interface, I'd vote for including them as a potential break.

@SeanFeldman
Copy link
Contributor

SeanFeldman commented May 20, 2016 via email

@SimonCropp
Copy link
Contributor

yeah i think it is a breaking change. that and additional abstract members

@andreasohlund
Copy link
Owner

Makes sense to me, that was a nice find. Always had the mental model that "adding is always safe", thanks for the wake up call @bording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants