-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APIComparer not showing changes to interfaces #69
Comments
We haven't been showing additions since we always considered them non breaking changes. But interfaces is interesting since additions would be be non breaking for consumers but breaking for implementors. @ParticularLabs/apicomparer thoughts? |
Given that one scenario around public interfaces is allowing you to provide your own implementation of the interface, I'd vote for including them as a potential break. |
Tend to agree with Brandon.
|
yeah i think it is a breaking change. that and additional abstract members |
Makes sense to me, that was a nice find. Always had the mental model that "adding is always safe", thanks for the wake up call @bording |
While comparing the changes in the latest RabbitMQ client, it appears that APIComparer is missing some of the changes that were made:
http://apicomparer.particular.net/compare/RabbitMQ.Client/3.6.1...3.6.2
Here is the comparison of what all was changed between 3.6.1 and 3.6.2:
rabbitmq/rabbitmq-dotnet-client@rabbitmq_v3_6_1...rabbitmq_v3_6_2
For example, there was a new property added to
IConnection
but that isn't showing up in the comparison. Since changes to an interface are always going to break implementors, I expected to see it listed.The text was updated successfully, but these errors were encountered: