Bug fixes client.py #114
Open
Bug fixes client.py #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutable Default Argument:
Issue: The original code used provider_configs: dict = {} as a default argument. This could lead to unintended side effects due to Python's handling of mutable defaults.
Fix: Changed provider_configs to None and initialized it with {} inside the method.
Repetitive Validation:
Issue: Both Client and Completions contained redundant logic for provider validation.
Fix: Centralized validation logic into _validate_provider_key and reused it.
Unclear Error Handling:
Improved error messages for easier debugging.
Lazy Initialization:
Ensured lazy initialization for properties (chat and completions).
|
This is a duplicate PR. There is already a PR with the same idea which waits to be approved opened earlier. |
|
Sorry, my bad
…On Sat, Nov 30, 2024 at 7:06 PM Sermet Pekin ***@***.***> wrote:
This is a duplicate PR. There is already a PR with the same idea which
waits to be approved opened earlier.
#84 <http://url>
#84 <#84>
—
Reply to this email directly, view it on GitHub
<#114 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXOCKXQQUSYWS5EXIFN3AK32DHA5ZAVCNFSM6AAAAABSYR4G2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYHE3TGMBUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutable Default Argument:
Issue: The original code used provider_configs: dict = {} as a default argument. This could lead to unintended side effects due to Python's handling of mutable defaults.
Fix: Changed provider_configs to None and initialized it with {} inside the method.
Repetitive Validation:
Issue: Both Client and Completions contained redundant logic for provider validation.
Fix: Centralized validation logic into _validate_provider_key and reused it.
Unclear Error Handling:
Improved error messages for easier debugging.
Lazy Initialization:
Ensured lazy initialization for properties (chat and completions).