-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of warnings and errors popping into the log #11
Conversation
Fixing warning popping into log (uncaught typeerror: data.push is not a function)
Fix warning popping into log (Uncaught TypeError: Cannot read property 'state' of undefined, or Uncaught TypeError: Cannot read property 'attribute' of undefined)
Change revision date
Bad news... after 12 hours without any "Uncaught TypeError: e.push is not a function", it came back :'( EDIT - IT WORKS, just changed computer and had to clear cache (Ctrl+F5) |
too bad. btw, this:
is not an error in the custom-ui, it is the user not defining the templates correctly.... always have them check for state/existence , or not being none.. you should use that error as feedback to improve your templates ;-) please take out that 'fix' since it isn't. |
Sorry, It worked, I'm not on the same computer as yesterday and I had to do a Ctrl+F5 to clear cache, it works :D |
Ok, but I don't understand from where comes those errors :( just walk through all your templates in custom-ui and look for the 'attributes' . You are templating that on an entity that doesnt (yet) exist. |
Cancel the fix for 'state' or 'attribute' underfined
Removed the 'Fix', keeping only the e.puch error which works after cache clearing (Ctrl+F5) |
24 hours now without e.push errors 🤗 |
these errors only happen when browsing the settings tab in the left side menu. Did you check that? |
thanks to @SupremeSports who created this PR #11 edited in the custom-ui file directly since the PR contained more than this error catch.
edited the file manually after successfully testing locally, so closing this PR to avoid version conflicts or multiple edit errors. |
Absolutely, I had these errors only in those cases. Tested and fixed for me |
Hi, this fixes the error saying "Uncaught TypeError: e.push is not a function". This was generating dozens of errors.
Tested on my HA and works great, please ensure it works with everything Custum-UI is supposed to do as I only use it in yaml.