Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemap not working with awesome-typescript-loader #24

Closed
timofei-iatsenko opened this issue Aug 4, 2016 · 7 comments
Closed

Sourcemap not working with awesome-typescript-loader #24

timofei-iatsenko opened this issue Aug 4, 2016 · 7 comments

Comments

@timofei-iatsenko
Copy link
Contributor

loaders: [
      {
        test: /\.[tj]s$/,
        loaders: ['ng-annotate', 'awesome-typescript-loader'],
        exclude: /node_modules/,
      },

i'm using devtool: 'cheap-module-source-map', option.

And see in console:

Failed to parse SourceMap: ...

awesome-typescript-loader is version 1.1.1, with typescript 1.8

@andrey-skl
Copy link
Owner

@thekip does this work without 'ng-annotate' loader?

@timofei-iatsenko
Copy link
Contributor Author

Surely

@timofei-iatsenko
Copy link
Contributor Author

Actually it's not so easy to reproduce, i've created a small application and bug is not appear.

Also i turned cheap-module-source-map to inline-cheap-module-source-map and looks like now it works.

I will research more.

@timofei-iatsenko
Copy link
Contributor Author

Looks like now it works with cheap-module-source-map as well. I don't know what was the problem.

But now has another problem, file listed twice in source maps, and source map weight is twice bigger.

Symptoms looks same as in this issue: #23 :

"webpack:///./index.js",
"webpack:///./index.js?2645",
"webpack:///..//angular/index.js",
"webpack:///../
/angular/index.js?08f2",
"webpack:///..//angular/angular.js",
"webpack:///../
/angular/angular.js?58d0",

But in my case SourceMaps still work.

timofei-iatsenko added a commit to timofei-iatsenko/ng-annotate-loader that referenced this issue Aug 29, 2016
@thielmal
Copy link

Can confirm that this commit fixed the issue for me. What's the status on a npm release of 0.1.2?

@andrey-skl
Copy link
Owner

Glad to hear! Let's publish it in a next few hours then.

@andrey-skl
Copy link
Owner

@LucasThielmann Published as 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants