Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mac.binary.big-sur-arm64 #142

Closed
vnijs opened this issue Jun 18, 2021 · 5 comments
Closed

Support mac.binary.big-sur-arm64 #142

vnijs opened this issue Jun 18, 2021 · 5 comments

Comments

@vnijs
Copy link
Contributor

vnijs commented Jun 18, 2021

I tried the below but makeRep doesn't work for ARM macOS packages

download <- makeRepo(pkgs, path = pth, type = "mac.binary.big-sur-arm64", Rversion = "4.1")

If you could update repoPrefix as below all should be well. Thanks

repoPrefix <- function(type, Rversion) {
  Rversion <- twodigitRversion(Rversion)

  if ((type == "mac.binary.el-capitan") && (numeric_version(Rversion) < "3.4")) {
    warning("Type mac.binary.el-capitan only valid for R >= 3.4")
  } else if ((type == "mac.binary.mavericks") && (numeric_version(Rversion) >= "3.4")) {
    warning("Type mac.binary.mavericks only valid for R < 3.4")
  }

  switch(
    type,
    "source" = "src/contrib",
    "win.binary" = sprintf("bin/windows/contrib/%s", Rversion),
    "mac.binary" = sprintf("bin/macosx/contrib/%s", Rversion),
    "mac.binary.el-capitan" = sprintf("bin/macosx/el-capitan/contrib/%s", Rversion),
    "mac.binary.big-sur-arm64" = sprintf("bin/macosx/big-sur-arm64/contrib/%s", Rversion),
    "mac.binary.leopard" = sprintf("bin/macosx/leopard/contrib/%s", Rversion),
    "mac.binary.mavericks" =  sprintf("bin/macosx/mavericks/contrib/%s", Rversion),
    stop("Type ", type, " not recognised.")
  )
}
@vnijs
Copy link
Contributor Author

vnijs commented May 2, 2022

Minor update:

repoPrefix <- function(type, Rversion) {
  Rversion <- twodigitRversion(Rversion)

  if ((type == "mac.binary.big-sur-arm64") && (numeric_version(Rversion) < "4.1")) {
    warning("Type mac.binary.big-sur-arm64 only valid for R >= 4.1")
  } else if ((type == "mac.binary.el-capitan") && (numeric_version(Rversion) < "3.4")) {
    warning("Type mac.binary.el-capitan only valid for R >= 3.4")
  } else if ((type == "mac.binary.mavericks") && (numeric_version(Rversion) >= "3.4")) {
    warning("Type mac.binary.mavericks only valid for R < 3.4")
  }

  switch(type,
    "source" = "src/contrib",
    "win.binary" = sprintf("bin/windows/contrib/%s", Rversion),
    "mac.binary" = sprintf("bin/macosx/contrib/%s", Rversion),
    "mac.binary.el-capitan" = sprintf("bin/macosx/el-capitan/contrib/%s", Rversion),
    "mac.binary.big-sur-arm64" = sprintf("bin/macosx/big-sur-arm64/contrib/%s", Rversion),
    "mac.binary.leopard" = sprintf("bin/macosx/leopard/contrib/%s", Rversion),
    "mac.binary.mavericks" =  sprintf("bin/macosx/mavericks/contrib/%s", Rversion),
    stop("Type ", type, " not recognised.")
  )
}

@maksymiuks
Copy link

Hi @andrie, do you plan on addressing these changes to the infrastructure?

@achubaty
Copy link
Collaborator

@andrie this looks the same as PR #152, which was passing checks and likely ready to be merged

@andrie
Copy link
Owner

andrie commented Mar 20, 2024

Thank you. I've merged #152 and am now slowly working to fix all the tests that broke because MRAN no longer exists.

@maksymiuks
Copy link

Thank you very much @andrie

If you need MRAN time machine functionality I suggest using Posit Package Manger public instance and its snapshots :)

@andrie andrie closed this as completed Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants