Refactor example-sdk to runtime_enabled-sdk #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiwangi-shah
requested review from
kolea2,
notmariazoe,
cshmerling,
robclifford27,
erintwalsh and
jmarkoff
as code owners
notmariazoe
requested changes
Nov 26, 2024
PrivacySandboxKotlin/settings.gradle
Outdated
| @@ -33,12 +33,12 @@ dependencyResolutionManagement { | |||
|
|
|||
| rootProject.name = "PrivacySandboxSample" | |||
| include ':client-app' | |||
| include ':example-sdk' | |||
| include ':example-sdk-bundle' | |||
| include ':runtime_enabled-sdk' | |||
There was a problem hiding this comment.
Would you mind renaming to avoid underscores? Underscores are generally disallowed in Kotlin naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
for readability. The runtime_enabled sdk is the sdk that is loaded in the sdk runtime process and acts as an ad network or as a mediator.