Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config access pattern class #40

Open
andykais opened this issue Oct 13, 2019 · 0 comments
Open

config access pattern class #40

andykais opened this issue Oct 13, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@andykais
Copy link
Owner

There is data from a config that I want to access but I feel like anyone using the library should not care about the structure of the config after creating a scraper. Data I want to access is:

  • inputs
  • scraper names

depends on what I want to make the access pattern. Either:

const { start, query, info } = scrape(config, options, params)
info.getInputs()
info.getScraperNames()

or

const scraper = new Scraper(config, options, params)
await scraper.start()
scraper.query(...)
scraper.getInputs()
scraper.getScraperNames()
@andykais andykais added the enhancement New feature or request label Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant