Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check behavior of radiometry._interp_common #55

Open
andykee opened this issue Sep 19, 2024 · 0 comments
Open

Check behavior of radiometry._interp_common #55

andykee opened this issue Sep 19, 2024 · 0 comments

Comments

@andykee
Copy link
Owner

andykee commented Sep 19, 2024

lentil/lentil/radiometry.py

Lines 900 to 903 in 5f471c0

# compute a common wavelength array that spans both spectrum and has the
# desired sampling
minwave = min(s1.wave.min(), s2.wave.min())
maxwave = max(s1.wave.max(), s2.wave.max())

I think the intent of _interp_common() is to extract the smallest overlapping region of wavelengths. What is actually happening is that the full extent of wavelengths is being extracted.

Should think about what the right thing to do here is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant