Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepia is Causing Duplicate Requests #2

Closed
aneilbaboo opened this issue Mar 25, 2017 · 1 comment
Closed

Sepia is Causing Duplicate Requests #2

aneilbaboo opened this issue Mar 25, 2017 · 1 comment

Comments

@aneilbaboo
Copy link
Owner

aneilbaboo commented Mar 25, 2017

This problem was originally discovered in sepia (from which this was forked): LinkedInAttic/sepia#12

It should be easy enough to fix in replayer. The replacement functions are named "replayerRequest", so we should be able to fix this by checking whether protocolModule.request.name=='replayerRequest'. We'll still need to capture the original request method. However, the way the code is currently written, we won't have a copy of the original request method anymore in the second iteration of the loop in cache.js:

['http', 'https'].forEach(function (protocol) {
   ...
}
@aneilbaboo
Copy link
Owner Author

I think this was addressed by #1, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant