Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup and Restore Funtionality #114

Open
Honkertonken opened this issue Sep 15, 2024 · 6 comments
Open

Backup and Restore Funtionality #114

Honkertonken opened this issue Sep 15, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers todo Pending action

Comments

@Honkertonken
Copy link

Description

I currently have around 11 custom filters and would greatly appreciate an option to backup and restore these filter lists. Additionally, it would be great if this package were available on winget.

Otherwise, amazing app, keep up the great work :)

@Honkertonken Honkertonken added the enhancement New feature or request label Sep 15, 2024
@anfragment
Copy link
Owner

Glad you enjoy the app! Adding this to the backlog.

@anfragment anfragment added good first issue Good for newcomers todo Pending action labels Sep 16, 2024
@Noahnut
Copy link
Contributor

Noahnut commented Oct 21, 2024

Hi
I think I can do it

In my design I will

  • Front Design
    In my design I may add a export and Import button at the right side of the Custom Filter Lists
  • Export Feature
    export filter meta data as the file (Toml or Json)
  • Import Feature
    Read the File to the filter and apply it

@anfragment
Copy link
Owner

Hello @Noahnut! Sounds great; feel free to work on the issue.
Here’s a beginner’s guide to the project that you can use to get started: https://github.com/anfragment/zen/blob/master/docs/internal/index.md#getting-started.

Regarding the format, I think JSON is a better fit since we’re already using it, and Go’s standard library provides a package for it.

@Noahnut
Copy link
Contributor

Noahnut commented Nov 2, 2024

Hello @anfragment
The UI will like the photo.
Is that ok ?
I will export and import the custom filter only.

image

@anfragment
Copy link
Owner

@Noahnut looks neat, love it! A few minor UX suggestions:

  • I'd consider removing the "primary" intent on the "More Options" button to align its prominence with its significance on the page.
  • The labels could be shortened, as the context makes their purpose clear: “More Options” could become “Options,” “Export Custom Filter Lists” could be “Export,” and “Import Custom Filter Lists” could be “Import.”

When implementing, could you please ensure the import button appends new lists rather than overwriting existing ones?

@Noahnut
Copy link
Contributor

Noahnut commented Nov 3, 2024

@anfragment Thank for your advise ! I will follow your advise.
Yes, I will append the import filter list to the original list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers todo Pending action
Projects
None yet
Development

No branches or pull requests

3 participants