Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1210 in material.angular.io https://github.com/angular/ma… #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darpankumar
Copy link

This PR fix the issue issue 1210 in which autofilled property is not mentioned in the document along with this added another missing property documentation. Please let me know if any changes are require.

After fix document screenshot.
angular-doc

Copy link

google-cla bot commented Nov 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@darpankumar darpankumar reopened this Nov 14, 2023
@DmitryEfimenko
Copy link

Thanks for the PR! I am happy to see the description of what would happen if the property autofilled is set to true or false.
However, I think there's still room for improvement in the following sentence:

This property allows us to specify Whether the input is currently in an autofilled state.

First, the word "Whether" should be lower-case.
Second, and most important - I still don't understand what would be the situation when a developer should set the autofilled property to true or false. Is it referring to the browser's autofill functionality? In that case, how can develop identify if the control was autofilled? Or is this referring to something else? A description of a concrete situation when this property should be set would be helpful.

@darpankumar
Copy link
Author

Hi @DmitryEfimenko I will fix the word.
As per my understanding this is similar to the case where we mark a control touched/disabled. Similarly we need to implement this flag with true or false when the property is auto filled by the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants