-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS thread stalls when using multiple animations #48
Comments
Web workers cannot access the dom |
Is it DOM manipulation that's stalling it? Was thinking we could offload all the interpolations and such, and use |
Not sure what exact issue you are having. Can you post an example where you are seeing it stall? |
Uhh yeah, releasing a pretty big UI library in a couple days that depends on |
Alright, it's up: https://carbon-ui.com It's not as noticeable on production, and I did some optimizations, but in the menu especially there's some jag |
We could also cleverly implement |
That would honestly probably be more complicated and brittle. I haven't done any profiling on this but the animated lib uses rAF and direct manipulation of the DOM so I'm not totally certain about where the slowness is coming from. |
For the record this is a total beta library, never anticipated it being deployed in a production library. |
@tuckerconnelly can you put up a minimal example that creates some slowness? perhaps a codepen? How many simultaneous animations are we talking about here? |
It just stalls for a second. Could do what React Native is doing and offload animations to a WebWorker.
The text was updated successfully, but these errors were encountered: