Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haho.moe source does not have settings to change preferred quality. #2494

Closed
7 tasks done
ravener opened this issue Nov 10, 2023 · 5 comments · Fixed by #2498
Closed
7 tasks done

Haho.moe source does not have settings to change preferred quality. #2494

ravener opened this issue Nov 10, 2023 · 5 comments · Fixed by #2498
Labels
Bug Something isn't working

Comments

@ravener
Copy link

ravener commented Nov 10, 2023

Source information

haho.moe 13.8 (English)

Source language

English

Steps to reproduce

The video player can change quality just fine but there's no preferences screen to change the preferred quality for downloading.

Expected behavior

There should be extension settings to change preferred quality.

Actual behavior

There isn't one implemented yet.

Aniyomi version

0.12.3.10

Android version

Android 9

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.12.3.10.
  • I have updated all installed extensions.
  • I have tried the troubleshooting guide.
  • If this is an issue with the app itself, I should be opening an issue in the app repository.
  • I will fill out all of the requested information in this form.
@ravener
Copy link
Author

ravener commented Nov 12, 2023

@jmir1 @Claudemirovsky Thanks for the fast update but it seems to be completely broken on the latest stable version, on the preview it mostly works but some titles keep giving a NullPointerException when loading the episodes list.

@Claudemirovsky
Copy link
Contributor

Magnificient, i'll fix this regression after today's exams.
Btw, can you share a example of entry where the episode list fails? When I tested it, none gave this error (and that's why I pushed it).

@ravener
Copy link
Author

ravener commented Nov 12, 2023

Btw, can you share a example of entry where the episode list fails? When I tested it, none gave this error (and that's why I pushed it).

Seems to happen to most of the entries in the popular list, but If I have to pick one to demonstrate:

Screenshot_20231112_220125_xyz jmir tachiyomi mi debug

@Claudemirovsky
Copy link
Contributor

Seems to happen to most of the entries in the popular list, but If I have to pick one to demonstrate:
[ Screenshot with Majo no Kekkyoku ]

Thanks, could confirm. This should be fixed in #2507.
Btw, nice felix pic in your profile 👍

@ravener
Copy link
Author

ravener commented Nov 14, 2023

Can confirm that fixed it, also works on the non-preview version now. 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants