Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Image for Builds #2

Open
VikashKothary opened this issue Jul 31, 2020 · 7 comments
Open

Docker Image for Builds #2

VikashKothary opened this issue Jul 31, 2020 · 7 comments

Comments

@VikashKothary
Copy link
Member

VikashKothary commented Jul 31, 2020

We've now got a CI for https://github.com/ankicommunity/anki-sync-server. It needs a docker image for build process. I'm currently using this this image but it doesn't allow building the lastest verson of the psutil library.

Adding this would fix that:

$ RUN apk add --update gcc libc-dev linux-headers && rm -rf /var/cache/apk/*

Source: giampaolo/psutil#664.

Alternatively, we could have separate development and prod images, which would probably be better in the long term.

@kuklinistvan
Copy link
Collaborator

Hey, sorry, I did not see this - I'm watching this repository from now. Is this still relevant?

@VikashKothary
Copy link
Member Author

VikashKothary commented Aug 23, 2020

Yep. Still relevant but not urgent. Basically we need separate Docker images for development and production. Any thoughts?

@kuklinistvan
Copy link
Collaborator

Hello,

if I understand you, would rebuilding the image with up-to-date libraries resolve the problem?

@VikashKothary
Copy link
Member Author

Nope. The current docker image is for running the anki sync server and it runs fine.

But for development we've got other libraries e.g. for testing, linting, building documentation, etc. Once of those libraries psutil doesn't work on alpine linux without the above dependencies.

We could add the dependency to the existing docker image, however, that would increase the size of the image and would be pointless for 90% of users. This is why I was recommending creating a second docker image.

I'll assign myself to the issue. Just wanted to run it past you first.

@kuklinistvan
Copy link
Collaborator

Ah I see, okay.

@fw-aaron
Copy link

@VikashKothary Would you mind submitting a pull request?

@VikashKothary
Copy link
Member Author

@fw-aaron it would be much appreciated 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants