-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Image for Builds #2
Comments
Hey, sorry, I did not see this - I'm watching this repository from now. Is this still relevant? |
Yep. Still relevant but not urgent. Basically we need separate Docker images for development and production. Any thoughts? |
Hello, if I understand you, would rebuilding the image with up-to-date libraries resolve the problem? |
Nope. The current docker image is for running the anki sync server and it runs fine. But for development we've got other libraries e.g. for testing, linting, building documentation, etc. Once of those libraries We could add the dependency to the existing docker image, however, that would increase the size of the image and would be pointless for 90% of users. This is why I was recommending creating a second docker image. I'll assign myself to the issue. Just wanted to run it past you first. |
Ah I see, okay. |
@VikashKothary Would you mind submitting a pull request? |
@fw-aaron it would be much appreciated 👍🏽 |
We've now got a CI for https://github.com/ankicommunity/anki-sync-server. It needs a docker image for build process. I'm currently using this this image but it doesn't allow building the lastest verson of the
psutil
library.Adding this would fix that:
Source: giampaolo/psutil#664.
Alternatively, we could have separate development and prod images, which would probably be better in the long term.
The text was updated successfully, but these errors were encountered: