Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the relationship between shortcut and sync #17773

Open
Arthur-Milchior opened this issue Jan 8, 2025 · 0 comments
Open

Investigate the relationship between shortcut and sync #17773

Arthur-Milchior opened this issue Jan 8, 2025 · 0 comments

Comments

@Arthur-Milchior
Copy link
Member

How to reproduce:

  • Have a deck D with cards to review
  • enable automated sync
  • create a shortcut to D
  • do some review.
  • force cloze anki by swapping the app on the android app list, ensuring it does not sync on cloze
  • wait 10 minutes
  • open the deck D through the shortcut

With a recent change I introduced, this open the deck picker and automatically open the reviewer on top of it. I think I saw the sync view opening on top of the deck picker during not even a second.
We need to investigate what's going on exactly in the deck picker, related to sync.

Because, if the automated sync goes on and finish in 1 second, that's great. Data is synced, maybe media sync is ongoing, that's perfect. That even solved an issue I had related to sync and shortcut, and I would have solved it by accident.

If a force sync is needed, it seems that nothing occurs. Which is okay-ish. The user should probably be warned they need to force sync before they start their review. We should surely improve the behavior here.

What I'm effrayed is that if there is a long sync. Due to a lot of changes, new decks, card reviewed, you're on a device you've not used in months, and you have a slow internet connection, you may be able to start reviewing while sync is going on. And ankidroid is really not prepared to have anything going on in parallel to a collection sync.

I'm not sure. Someone need to investigate what is going on. Probably using breakpoint in the codebase to check whether sync is aborted, sync is going on normally, whether we can actually review while sync is going on (which would be quite bad)

Of course, this someone can be me when I've some free time and my mind is awake enough to be sure of my investigation. But if anyone else want to take a look, I'd appreciate that a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant