feat: Improve Check Media dialog #17842
Open
+86
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Maintainers: This PR contains Strings changes
|
criticalAY
force-pushed
the
feat-check-media
branch
from
b6f458d to
1bba6f3
Compare
criticalAY
force-pushed
the
feat-check-media
branch
from
1bba6f3 to
e168034
Compare
criticalAY
changed the title
david-allison
requested changes
Jan 19, 2025
| @@ -33,6 +36,8 @@ class MediaCheckDialog : AsyncDialogFragment() { | |||
| fun mediaCheck() | |||
|
|
|||
| fun deleteUnused(unused: List<String>) | |||
|
|
|||
| fun tagMissing(missingMediaNotes: List<Long>?) | |||
There was a problem hiding this comment.
Use the ViewModel, or a Fragment listener, we want to move away from interfaces
Comment on lines
+114
to
+132
| val noHaveFormatted = noHave.joinToString("\n") { TR.mediaCheckMissingFile(it) } | ||
| val unusedFormatted = unused.joinToString("\n") { TR.mediaCheckUnusedFile(it) } | ||
|
|
||
| val formattedList = | ||
| buildString { | ||
| if (noHaveFormatted.isNotEmpty()) { | ||
| append(TR.mediaCheckMissingHeader()) | ||
| append("\n") | ||
| append(noHaveFormatted) | ||
| append("\n\n") | ||
| } | ||
|
|
||
| if (unusedFormatted.isNotEmpty()) { | ||
| append(TR.mediaCheckUnusedHeader()) | ||
| append("\n") | ||
| append(unusedFormatted) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This would be useful to extract to a method so we can test it
| @@ -196,6 +239,7 @@ class MediaCheckDialog : AsyncDialogFragment() { | |||
| UNUSED to ArrayList(checkList.unusedFileNames), | |||
| INVALID to ArrayList(checkList.invalidFileNames), | |||
| MEDIA_CHECK_DIALOG_TYPE_KEY to dialogType.code, | |||
| MISSING_MEDIA_NOTES to ArrayList(checkList.missingMediaNotes).toList(), | |||
There was a problem hiding this comment.
This will eventually throw a TransactionTooLargeException. When?
Comment on lines
+114
to
+116
| val noHaveFormatted = noHave.joinToString("\n") { TR.mediaCheckMissingFile(it) } | ||
| val unusedFormatted = unused.joinToString("\n") { TR.mediaCheckUnusedFile(it) } | ||
|
|
david-allison
added
the
Needs Author Reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Make the media check dialog consistent with Anki, and allow tagging missing media file notes
Fixes
How Has This Been Tested?
Learning (optional, can help others)
More about the Anki codebase
Checklist
Please, go through these checks before submitting the PR.