Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do cleanup in examples #235

Open
reynir opened this issue Jan 5, 2024 · 1 comment
Open

Do cleanup in examples #235

reynir opened this issue Jan 5, 2024 · 1 comment

Comments

@reynir
Copy link
Contributor

reynir commented Jan 5, 2024

In the (client) examples resource cleanups is not done properly. That is, file descriptors are not closed once a request has been made. You could say it is okay as the operating system will do the cleanup at exit, but in my opinion I think it is crucial to show how to do proper resource cleanup in the example as well.

Please correct me if I am mistaken.

@anmonteiro
Copy link
Owner

I believe you're correct, and we should be calling Client.shutdown. Thanks for the catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants