feat/1304 - Namadillo: Add commit hash to Settings, link to revision #1305
+41
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
reviewed
Nov 22, 2024
apps/namadillo/package.json
Outdated
| "preview": "vite preview", | ||
| "dev:local": "NODE_ENV=development NAMADA_INTERFACE_LOCAL=\"true\" yarn dev", | ||
| "dev:proxy": "VITE_PROXY=true && ./scripts/start-proxies.sh && yarn dev:local", | ||
| "build": "NODE_ENV=production && yarn wasm:build && vite build", | ||
| "build:only": "NODE_ENV=production && vite build", | ||
| "build": "NODE_ENV=production && yarn wasm:build && yarn git:hashes && VITE_GIT_SHORT=$(git rev-parse --short HEAD) VITE_GIT_LONG=$(git rev-parse HEAD) vite build", |
There was a problem hiding this comment.
can't we use only yarn git:hashes && vite here?
There was a problem hiding this comment.
@euharrison that was the idea, but it doesn't work for me yet. Still a WIP, I will fix soon!
There was a problem hiding this comment.
Unfortunately, I couldn't get the envs to pass from one script to another, so I simplified it to one var and included where necessary. I guess this is fine for now /shrug
jurevans
changed the title
jurevans
force-pushed
the
feat/1304-git-hash-version
branch
from
67c65d8 to
3a9f693
Compare
jurevans
force-pushed
the
feat/1304-git-hash-version
branch
from
3a9f693 to
db650ba
Compare
euharrison
approved these changes
Nov 22, 2024
mateuszjasiuk
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1304
For Namadillo & Namada Keychain, this PR adds the current Git revision to display in the respective settings view
NOTE
CopyToClipboardcontrol for the full revision hash. I messed around with this, would work well, but also forces user to do more. I think at the least we should have the link, but maybe in the future offer the copy-to-clipboard in addition to it? Just a thought.Screenshots
Namadillo:
Namada Keychain:
