IBC Packet Forward Middleware #4082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4082 +/- ##
==========================================
- Coverage 74.58% 74.51% -0.08%
==========================================
Files 341 342 +1
Lines 107484 107894 +410
==========================================
+ Hits 80167 80396 +229
- Misses 27317 27498 +181 ☔ View full report in Codecov by Sentry. |
sug0
force-pushed
the
bat+tiago/feat/ibc-pfm
branch
from
0cf7093
to
dc3950c
Compare
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
|
(before rebase/history cleanup: dc3950c) |
sug0
force-pushed
the
bat+tiago/feat/ibc-pfm
branch
from
dc3950c
to
c9c8d57
Compare
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
sug0
force-pushed
the
bat+tiago/feat/ibc-pfm
branch
from
c9c8d57
to
7b6135d
Compare
yito88
approved these changes
Nov 29, 2024
| @@ -118,9 +119,10 @@ fs_extra = "1.2.0" | |||
| futures = "0.3" | |||
| git2 = { version = "0.18.1", default-features = false } | |||
| # branch yuji/derive-arbitrary | |||
There was a problem hiding this comment.
Updating the branch name would be helpful
| @@ -534,7 +529,7 @@ pub fn make_hermes_config(test_a: &Test, test_b: &Test) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn make_hermes_chain_config(test: &Test) -> Value { | |||
| fn make_hermes_chain_config(_hermes_dir: &TestDir, test: &Test) -> Value { | |||
grarco
reviewed
Nov 30, 2024
| &test_gaia_2, | ||
| )?; | ||
|
|
||
| // Check the samoleans have been sent from the first cosmos chain |
grarco
reviewed
Nov 30, 2024
| self.transfer_module.ctx.inner.clone(), | ||
| self.transfer_module.ctx.verifiers.clone(), | ||
| ); | ||
| self.transfer_module.ctx.insert_verifier(&MULTITOKEN); |
There was a problem hiding this comment.
Do we need this also for send_transfer_execute?
grarco
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Integrate with the Packet Forward Middleware code. Requires an
ibc-rsfork, in order to support asynchronous IBC packet acknowledgements.NOTE: The code in the links above should also be reviewed.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo