Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Datasources aren't possible #114

Open
rockaut opened this issue Aug 11, 2020 · 5 comments
Open

Plugin Datasources aren't possible #114

rockaut opened this issue Aug 11, 2020 · 5 comments

Comments

@rockaut
Copy link
Contributor

rockaut commented Aug 11, 2020

SUMMARY

Currently the possible datasources are hardcoded so ds from plugins like camptocamp-prometheus-alertmanager-datasource aren't possible.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

grafana_datasource

@rockaut
Copy link
Contributor Author

rockaut commented Aug 13, 2020

Possible solution:

If it's not possible to get if the datasource type exists currently (at least not without cli access which should be a nogo for this module!) then I would pledge to just create it as provided. If the implement a way we can update the module.

@michaelpearce-gain
Copy link

michaelpearce-gain commented Aug 18, 2020

maybe an approach to store the data source config as api exportable json config, much like wizzy does, and is being done for dashboards, this way it becomes very flexible and removes some of the magic from the ansible modue.

As custom and new data sources (jaeger example of unsupported by module) all need different settings, even es 7 does now. As well as new features such as custom http headers. This way maintenance and duplication needed here would be less. Could even support vars in the json, by simply running the json through the template engine, before applying to the grafana api.

@michaelpearce-gain
Copy link

{
"orgId": 1,
"name": "raintank",
"type": "graphite",
"typeLogoUrl": "public/app/plugins/datasource/graphite/img/graphite_logo.png",
"access": "proxy",
"url": "https://tsdb-gw.raintank.io/graphite/",
"password": "",
"user": "",
"database": "",
"basicAuth": true,
"isDefault": false,
"jsonData": {},
"readOnly": false
}

@michaelamattes
Copy link
Contributor

I would create a PR to implement json generic api plugin usage. Please let me know if this would supported from your side ?

@keithf4
Copy link

keithf4 commented Dec 10, 2024

Any progress on this? We had started using this module but when we were unable to create a Prometheus Alertmanager datasource, it kind of put us at a roadblock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants