Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Pinboard #139

Open
gundalow opened this issue Oct 23, 2019 · 21 comments
Open

Grafana Pinboard #139

gundalow opened this issue Oct 23, 2019 · 21 comments
Labels

Comments

@gundalow
Copy link
Contributor

gundalow commented Oct 23, 2019

GitHub Grafana issues GitHub Grafana PRs Grafana pinboard

We could collectively benefit from forming a Working Group related to Grafana integration. We have quite some contributors on GitHub and users on IRC that are interested in improving this integration.

So this issue is a call for potential interested parties (earlier and existing contributors to Ansible). The benefits of having a Working Group is that members of the Working Group can:

  • test, review and add shipits to existing Grafana PRs
  • work collectively on the Grafana roadmap
  • provide a single-point-of-contact for interested Grafana contributors
  • collaborate on an Grafana Wiki
  • have a $team_grafana in BOTMETA.yml for auto-notifying team members
  • implement auto-labeling grafana issues and PRs
@gundalow
Copy link
Contributor Author

gundalow commented Oct 23, 2019

@seuf @rrey Feel free to use this issue for communication and https://github.com/ansible/community/wiki/Grafana for documentation.

Please give me a shout if there is anything else. I wonder if reviewing the existing PRs would be a good place to start

@rrey
Copy link
Collaborator

rrey commented Oct 23, 2019

Thank you @gundalow !

I'll start by reviewing the PRs !

@gundalow
Copy link
Contributor Author

Bot meta update ansible/ansible#63859
Means you can do shipit on any PR.
Any problems or questions please shout out. #ansible-devel on Freenode is the best place

@gundalow
Copy link
Contributor Author

gundalow commented Nov 6, 2019

Hi,
Could you please git mv the existing grafana modules to monitoring/grafana/ see https://github.com/ansible/ansible/pull/64497/files for an example.

I didn't want to do by myself now as there seem to be a number of open Grafana PRs https://ansible.sivel.net/pr/byfile.html (ctrl+f grafana). Once the new directory has been created the new module PRs will need rebasing and adding into the new directory.

Thanks

@rrey
Copy link
Collaborator

rrey commented Nov 10, 2019

@gundalow I made the PR here : ansible/ansible#64657

I think it can be merged after ansible/ansible#50816.
I will deal with the contributors on the other open PRs.

@rrey
Copy link
Collaborator

rrey commented Nov 17, 2019

@gundalow have no answer from author on ansible/ansible#50816 so I think we the ansible/ansible#64657 can be merged whenever you want. I have just rebased it, do you need any thing else on this PR ?

What are the next steps for working groups about the move to collections ?

@gundalow
Copy link
Contributor Author

@rrey Looks like the above got merged, which is great.

For the Grafana Working group the question is:

Would you want your own repo, or be in the general Community Collection repo?

Being in your own repo gives you some more control, and freedom to do a release of the Grafana collection independently of the main Community Collection.

I am looking for some willing Working Groups to test this out. Basically we'd freeze ansible/ansible and just do the work in the new collection repo.

I'm happy to jump on a call and discuss any of this if that may be easier.

@rrey
Copy link
Collaborator

rrey commented Nov 18, 2019

Hi !

I think it makes more sense to have a lifecycle for each working group.
I would go for a dedicated repo ! So you found a working group to test this out as far as I'm concerned !

@gundalow
Copy link
Contributor Author

@rrey @seuf Hi, I've created https://github.com/gundalow-collections/grafana which is a copy of what's currently in ansible/ansible:devel. It has basic CI (Python 3.6 on Ubuntu 1804). I've invited you both to the org, you should receive an email from GitHub to accept joining the team.

@gundalow
Copy link
Contributor Author

I wonder if one of the PRs from https://github.com/ansible/ansible/labels/grafana could be reworked for the new repo, perhaps ansible/ansible#62930 or ansible/ansible#64097 ?

@rrey
Copy link
Collaborator

rrey commented Nov 20, 2019

Thanks !
I think I can move ansible/ansible#62930 quickly on the collection repo. I'll start there.

@gundalow
Copy link
Contributor Author

@seuf if you want to jump on a call so we can discuss this, let me know.

@rrey
Copy link
Collaborator

rrey commented Dec 7, 2019

@gundalow what should we do for our modules maintenance ?

Should we use the gundalow-collections/grafana to push all the new fixes and content ?
Should we keep on fixing modules on ansible/ansible ?

@gundalow
Copy link
Contributor Author

@rrey @seuf I think we can ignore Grafana files in ansible/ansible for the moment.

I've just your closed the two PRs (one from each of you) that have been replicated in ansible-collections/grafana

  1. Should I move gundalow-collections/grafana to ansible-collections/grafana now, we can continue to prototype GitHub workflow there. I think this should be done before we ask anyone else to contribute to make it look more official (rather than in my personal GH Org)

  2. Do you think we are ready to ask https://github.com/ansible/ansible/pulls?q=label%3Agrafana+is%3Aopen+is%3Apr to re-create their PRs in the new repo?

@rrey
Copy link
Collaborator

rrey commented Dec 13, 2019

  1. Let's go !!

  2. Only #55651 is directly related to grafana. I think we can ask the author once the new repo is ready.

@gundalow
Copy link
Contributor Author

  1. Done https://github.com/ansible-collections/grafana
    You should both receive emails that invite you to be members of the new repo.

  2. I've put a comment on Add Thruk as Grafana Datasource ansible/ansible#55651 lets see how that works out.

@dericcrago
Copy link

I'm going to try to migrate this pinboard to https://github.com/ansible-collections/community.grafana but there may be a slight disruption as it requires multiple moves. I will follow up when the migration has been completed.

@dericcrago dericcrago transferred this issue from ansible/community Dec 4, 2020
@dericcrago dericcrago transferred this issue from ansible/transfer-issues Dec 4, 2020
@dericcrago dericcrago pinned this issue Dec 4, 2020
@dericcrago
Copy link

migrated and pinned!

@Andersson007
Copy link
Contributor

Andersson007 commented Aug 26, 2021

I'm happy to announce that the registration (free) for the Ansible Contributor Summit is open.

Which day should you attend?

  • If you are wondering what it means to "contribute" to Ansible, or if you have been using Ansible for a while and are thinking of ways to get more involved with the project and community, then Day 1 (September 28, Tuesday) is for you!
  • If you have already been contributing or participating in our previous Contributor Summits, you are still welcome to attend Day 1, however we think that Day 2 (October 1, Friday) will be more interesting for you.

Refer to the registration page for details.

See you at the summit!

@dericcrago
Copy link

Reminder - AnsibleFest and Ansible Contributor Summit are 1 week away!

In case you missed it, we will also be having a Hackathon throughout the entire Ansible Contributor Summit and AnsibleFest. This is a great opportunity to collaborate in real time with other members of the Ansible Community!

For more info and the latest updates, please see the Ansible Contributor Summit 2021.09 HackMD.

@Andersson007
Copy link
Contributor

Reminder - Day 1 of the Ansible Contributor Summit and the Hackathon start tomorrow (Tuesday, 28 September 2021)!

For more info and the latest updates, please see the Ansible Contributor Summit 2021.09 HackMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants