Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow managing dashboards in subfolders #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenjaminSchubert
Copy link
Contributor

@BenjaminSchubert BenjaminSchubert commented Dec 10, 2024

SUMMARY

Since Grafana 11, it is possible to have dashboards in subfolders. This enables users to manage dashboards in those.

Fixes #410

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

grafana_dashboard

To Maintainers

I am not quite sure how to increase the code coverage there, as, as far as I can tell, this is tested through the integration tests. Is that a problem? If so, any pointers?

@BenjaminSchubert BenjaminSchubert force-pushed the bschubert/dashboard-in-folder branch from ba29eeb to 8ba881a Compare December 10, 2024 21:59
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.77%. Comparing base (f867ad3) to head (400b412).

Files with missing lines Patch % Lines
plugins/modules/grafana_dashboard.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
+ Coverage   72.12%   72.77%   +0.64%     
==========================================
  Files          21       21              
  Lines        2228     2233       +5     
  Branches      437      439       +2     
==========================================
+ Hits         1607     1625      +18     
+ Misses        455      439      -16     
- Partials      166      169       +3     
Flag Coverage Δ
integration 71.85% <71.42%> (+0.98%) ⬆️
sanity 23.23% <14.28%> (-0.07%) ⬇️
units 64.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since Grafana 11, it is possible to have dashboards in subfolders.
This enables users to manage dashboards in those.
@BenjaminSchubert BenjaminSchubert force-pushed the bschubert/dashboard-in-folder branch from f06c58f to 400b412 Compare December 11, 2024 21:24
@BenjaminSchubert BenjaminSchubert marked this pull request as ready for review December 11, 2024 21:29
- The parent folder UID.
- Available with subfolder feature of Grafana 11.
- Allows creating dashboards in subfolders
version_added: "2.2.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure what would be the next version, I'll let you handle that here?

(Would it be possible to get a new release once this is in? I can see quite a few things haven't been released. If not, is there need for help to be able to do so?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating dashboards in subfolders
1 participant