Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened to default_vm_settings in vmware_cluster_ha.py ? #2280

Open
willt opened this issue Jan 8, 2025 · 1 comment
Open

What happened to default_vm_settings in vmware_cluster_ha.py ? #2280

willt opened this issue Jan 8, 2025 · 1 comment

Comments

@willt
Copy link

willt commented Jan 8, 2025

You used to be able to set default_vm_settings in using vmware_cluster_ha.py
Now the option isn't there and is causing a diff to occur because what it thinks is default on the cluster is not.
It also used to return a diff showing what actually changed but now it just returns true/false
I believe all this was in
check_ha_config_diff and configure_ha

Also you used to be able to set heartbeat_datastores and now that option is gone.

Why did these options get removed? Can they be added back?

@ihumster
Copy link
Collaborator

ihumster commented Jan 9, 2025

The last changes in vmware_cluster_ha.py module were in version 2.x. I didn't find the option default_vm_settings in any branch. Are you sure you didn't make a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants