You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the ansible-lint --fix yaml reformatting does not respect the original quote style. This means that any double quotes get turned into single quotes, unnecessary quotes removed, etc. ruamel.yaml has the preserve_quotes=True option to prevent this.
While I agree that normalizing quotes this way can be handy in a lot of cases, this creates a lot of unintentional churn and huge diffs. This makes me avoid using it in existing repos.
I think instead of having this normalization on by default, with #3937, it would be preferable to have this as it's own rule with associated auto-fix.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Right now, the
ansible-lint --fix
yaml reformatting does not respect the original quote style. This means that any double quotes get turned into single quotes, unnecessary quotes removed, etc.ruamel.yaml
has thepreserve_quotes=True
option to prevent this.While I agree that normalizing quotes this way can be handy in a lot of cases, this creates a lot of unintentional churn and huge diffs. This makes me avoid using it in existing repos.
I think instead of having this normalization on by default, with #3937, it would be preferable to have this as it's own rule with associated auto-fix.
Beta Was this translation helpful? Give feedback.
All reactions