Allow importing licenses with a missing "usage" attribute #14326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This trivial change fixes AAP-14614.
The original issue happens when AAP is pulling a subscription from Red Hat Satellite, and the subscription is missing a "usage" attribute.
Many subscriptions lack a "usage" attribute, so this shouldn't cause AAP to fail with an error 400.
The error on AAP is a KeyError thrown by
sub['usage']
.The fix here is to allow this lookup to return a blank value with
sub.get('usage')
so the KeyError is never raised and the subscription import occurs just fine.ISSUE TYPE
COMPONENT NAME
AWX VERSION
No make installed in this lab AAP, so here is the RPM version.
ADDITIONAL INFORMATION
Logged in
tower.log
before this fix:Logged after the fix:
Nothing logged at INFO level or worse.