Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Readme to scope and purpose. #195

Open
3 tasks done
fkuep opened this issue Feb 13, 2024 · 1 comment
Open
3 tasks done

Adapt Readme to scope and purpose. #195

fkuep opened this issue Feb 13, 2024 · 1 comment

Comments

@fkuep
Copy link

fkuep commented Feb 13, 2024

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that ansible-rulebook is open source software provided for free and that I might not receive a timely response.

Feature type

Enhancement to Existing Feature

Feature Summary

Reflect in Project Readme, that ansble-eda wants to be for eda-server and not the reference implementation collection for ansible-rulebook.

Steps to reproduce

Create a pull request for a new event source.

Current results

Face a discussion on how this aligns with product goals.

Sugested feature result

Don´t create a pull request before You have checked eda-server´s milstones

Additional information

#196
#182 (comment)

fkuep added a commit to fkuep/event-driven-ansible that referenced this issue Feb 13, 2024
@fkuep
Copy link
Author

fkuep commented Feb 13, 2024

It should reduce pain, once poeple know it is too early to contribute event sources and that this project might have no use.
Perhaps contributing.md is a better place ?
People could be told to ask beforehand ?
https://github.com/ansible/event-driven-ansible/blob/main/CONTRIBUTING.md?plain=1#L5
The Term evaluation needs clarification: I would assume this means e.g.: a good test needs to be written.
From #182 I now understand, that a product team has meetings to decide, after the fact about the worthiness of the event source itsself not the contributed plugin quality.

fkuep added a commit to fkuep/event-driven-ansible that referenced this issue Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant