Code quality checklist

[ssbarnea]

This ticket is used to track progressive changes we need to make to the codebase in order to improve the code quality and prevent regression.

Tasks

Beta Give feedback

1. eslint: enforce "@typescript-eslint/no-non-null-assertion"
2. "strict": true in ALS tsconfig.js file see (might split it into multi-step)
3. eslint: enforce "no-empty-function"
4. eslint: enforce "no-case-declarations"
5. eslint: enforce "no-constant-condition"
6. eslint: enforce "no-control-regex"
7. eslint: enforce "no-prototype-builtins"
8. typescript-eslint: adopt strict-type-checked (keep last)

Blocked ones:

• adopt ESM (due vscode extensions not supporting them yet)
• adopt chai v5 (requires ESM codebase)

AAP-22902