Add modal example #2332
Add modal example #2332
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
+ Coverage 87.61% 87.83% +0.22%
==========================================
Files 45 45
Lines 8518 8518
==========================================
+ Hits 7463 7482 +19
+ Misses 1055 1036 -19 |
|
@ansys-reviewer-bot help |
|
I am sorry... I cannot understand your request. Options are:
|
|
@ansys-reviewer-bot review |
|
Okay, I will trigger a review of your PR. |
![ansys-reviewer-bot[bot]](https://avatars.githubusercontent.com/in/383621?s=60&v=4){kind=small}
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: ansys-reviewer-bot[bot] <143693109+ansys-reviewer-bot[bot]@users.noreply.github.com>
|
@RobPasMue it keeps posting comments... xDD |
|
@ansys-reviewer-bot stop review |
|
Okay, I will not perform any more reviews on your PR. |
|
Oohh.. I had to stop it manually |
|
@germa89 @RobPasMue Are we allowed to use the PR review bot on libraries not yet public? For example, can I use it on my PRs while drafting the PyAnsys Writer's Guide? |
|
Hi @germa89! Yes, you have to stop it manually for now. If you prefer some other behavior let us know :) And yes, @PipKat, you can use the bot on your projects as well if you want. The bot will never be public, what we made public is the package we use inside of it https://pypi.org/project/review-bot/ If you want to use it somewhere, just let me know :) either at
|
I would say that it is a bit weird to keep getting comments and comments after you have resolve them all. If I were a person, I would expect to get all the comments, for me later to address them all at once. But this is just my opinion. :) |
|
|
Hey, I agree its annoying 😄 I'd love to know how would you expect it to work! You are one of our first users, I want to adapt it 😄 |
|
I mean... presumably.. you only want a review when you are "ready" so either because you trigger it with the commands. Or even better, can we request the app as reviewer?? presumably we can... I wouldn't make the app approve PRs per se, just either request changes or leave comments. We could detag/tag the bot as reviewer to retrigger a review. I think this is a very natural way to work. Not sure how difficult it is to implement. |
|
Hmm I don't think we can add it as a reviewer easily. Whenever you go to a PR in which the bot hasn't performed a review yet, and you try to search for it, it doesn't show up... I think we might have to disable the "automatic" review behavior. And just put a comment saying, hey if you want to trigger a review you have to run blablabla stop review would in that case stop making sense so we could just delete it |
|
Pinging @AlejandroFernandezLuces for context |
Shit .. it is true. I am surprised. Funny you can ask the old bot
We could hack this by setting a team maybe? So the bot will jump in if we ask a team called "Reviewers" to review? I dont know ...
Yep.... I guess you could just make the bot post a message saying, "Hey! I'm available!" ... At least for some months, so people is aware of it. |
|
FYI the old bot is not really a bot, it is an actual account 😄 that's why you can ask it a review Yeah we could create a pseudo team (empty) that the bot listens to. That would be an option =) And I agree, let's disable it for now and make the greeting message available with the possible commands to run =) |
|
Can you open an issue on the service repo? https://github.com/ansys-internal/review-bot-service
|
Thanks to @mcMunich for suggesting it
Close #2310