components button md 파일 번역 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
👁 Visual-Regression Diff Building... ⏳
|
|
일단 큼지막한 md 파일 수정했고, 이후 tsx 파일과 연관된 부분들 ex) basic.md 도 추후 번역 예정입니다. |
owjs3901
requested changes
Oct 7, 2024
components/button/demo/basic.tsx
Outdated
| @@ -5,7 +5,7 @@ const App: React.FC = () => ( | |||
| <Flex gap="small" wrap> | |||
| <Button type="primary">Primary Button</Button> | |||
| <Button>Default Button</Button> | |||
| <Button type="dashed">Dashed Button</Button> | |||
| <Button type="dashed">Dashed Button12</Button> | |||
components/button/index.ko-KR.md
Outdated
| | disabled | Disabled state of button | boolean | false | | | ||
| | ghost | Make background transparent and invert text and border colors | boolean | false | | | ||
| | href | Redirect url of link button | string | - | | | ||
| | htmlType | Set the original html `type` of `button`, see: [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#type) | `submit` \| `reset` \| `button` | `button` | | | ||
| | htmlType | Set the original html `type` of `button`, see: [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-type) | string | `button` | | |
There was a problem hiding this comment.
https://developer.mozilla.org/ko/docs/Web/HTML/Element/button#attr-type
ko 로 변경되어야 합니다
There was a problem hiding this comment.
위의 문법에 따르면 en-US 인데 그냥 ko로 하면 될까요?
owjs3901
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 Feature 설명
📝 To-do
메인주제
📸 스크린샷
📚 참고문헌 / 기타