Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing any slider causes app to crash and darkroom mode not working #109

Open
TheCatCoder opened this issue Aug 6, 2016 · 4 comments
Open

Comments

@TheCatCoder
Copy link

Hi, I'm using an iPhone 6s (running 9.3.3) and I followed the installation instructions exactly and the app built on my phone without any issues. However, when I open the app, most of the interface is non responsive, and when I try to change the temperature slider, the app just crashes (closes to the home screen). When the "enabled" button finally works, it has no effect on the screens temperature. Also, the darkroom mode doesn't work correctly, and by that, I mean that it simply inverts your screens colors and nothing else. I know that it's supposed to turn everything red and black because that's what it did when I actually had it working on a previous device. The widget also has the same disfunctionality, and crashes whenever either button is pressed.

Anyone know why it might be doing this?

@TheCatCoder
Copy link
Author

So I found out what it was. The bundle Identifier says "com..GoodNight" by default, but the PrefixHeader.pch file says "group.com..goodnight"

So because the "GoodNight" word at the last is capitalized in one case but is not in the other, it causes that error that I describe above. I fixed it by making the prefix header have the same capitalization as the bundle identifiers.

I would suggest that the master code be changed so that both the bundle identifiers and the PrefixHeader file contain the same letter case for the "goodnight" portion. It causes an error that wouldn't occur if the master code file were correct to begin with.

@ecdfeaa2
Copy link
Contributor

The group.com...goodnight is not the bundle identifier. It's the app groups identifier (Can be found in Capabilities section of target).

@TheCatCoder
Copy link
Author

Good point.

When I reread through the instructions, it's unclear whether the bundle identifiers and the app group identifiers have to actually have the same exact string, but since many people will copy the the bundle identifier string and paste it into the app group part when they're first making the app group identifier, like I did, it seems like a good idea to still change or so that everything is consistent, even if the app group identifier can technically have a different string to the bundle identifiers.

Thanks for the clarification.

@ecdfeaa2
Copy link
Contributor

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants