Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides Laravel helper functions #3

Open
hackel opened this issue Jun 18, 2018 · 1 comment
Open

Overrides Laravel helper functions #3

hackel opened this issue Jun 18, 2018 · 1 comment

Comments

@hackel
Copy link

hackel commented Jun 18, 2018

The helpers.php file in this package is being loaded before Laravel's. This is causing a conflict, e.g. with the "with" function. Laravel's version includes a second callback parameter. This one does not. I haven't checked the other functions to make sure they are identical, so there could be other issues.

I believe the design of this package is broken, if it depends on you keeping it in-sync with Laravel upstream manually. Remarkably, there doesn't appear to be a way to tell composer which autoload_files to load first. It's clearly not using the order of dependencies in my composer.json.

FYI—the function in question was changed 9 months ago:
laravel/framework#21445

@Tarpsvo
Copy link

Tarpsvo commented Aug 12, 2019

Having the same conflict. Also when using with($value, callable $callback = null) function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants