-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mode: git-local
not having any impact
#88
Comments
changing
to
fixed this for me |
I'm having the same issue and the solution above doesn't work |
I have same problem. I have no idea how can i get commit hash from local / remote git repo. I'm attaching my config code below
|
are you using the latest version (1.2.2) of this package? there were some changes to the absorb feature recently |
Yes, i am using latest version 1.2.2. Unfortunately with no success :( Can we contact directly? I hope that we can resolve that issue and help others with same trouble here. |
You should all be using git absorb. The idea is the same, it will get the commit sha from your last commit, but the main difference is that you will be referring to the previous commit version. What I usually do is to use a git post-commit hook to absorb and create a commit just for the version with the message "Updated version to x.xx.xx (sha)". Too much people had problems running git-local directly, not only problems performance problems due to the app executing git too many times, but sometimes the result not being the expected one. We are using this package to clear some cache every time the version changes, so the version cannot be cached and it must be very fast, because it's happening on every request to the app. I would gladly accept any PR's that could fix things, if we really have any bugs here, because git-local was not removed from the package. |
I'm using the latest version. When I run What am I doing wrong? Here's my config file:
|
I am having the same issue. Nothing seems to be working based on the default configuration to set the commit number as the version. |
same problem here! |
I'm trying to use the git sha for the commit number by changing
mode: git-local
, but when I callphp artisan version
I getAPP version 1.0.0 (commit 100001)
instead of the sha. What am I doing wrong?According to the documentation, I should run
php artisan version:refresh
but I get a command not defined error.The text was updated successfully, but these errors were encountered: