From 7d09b50c712186ac666ec03a59e6216d091abc69 Mon Sep 17 00:00:00 2001
From: greg <greg.cusack@anza.xyz>
Date: Wed, 6 Mar 2024 21:31:58 +0000
Subject: [PATCH] remove test for valid_client_facing_addr since it is no
 longer used

---
 dos/src/main.rs                   |  4 ++--
 gossip/src/legacy_contact_info.rs | 18 ------------------
 programs/sbf/Cargo.lock           |  1 -
 3 files changed, 2 insertions(+), 21 deletions(-)

diff --git a/dos/src/main.rs b/dos/src/main.rs
index 0f7b74bcb7b747..055b1f4bb65d4c 100644
--- a/dos/src/main.rs
+++ b/dos/src/main.rs
@@ -47,8 +47,7 @@ use {
     rand::{thread_rng, Rng},
     solana_bench_tps::{bench::generate_and_fund_keypairs, bench_tps_client::BenchTpsClient},
     solana_client::{
-        connection_cache::ConnectionCache,
-        tpu_client::TpuClientWrapper,
+        connection_cache::ConnectionCache, tpu_client::TpuClientWrapper,
         tpu_connection::TpuConnection,
     },
     solana_core::repair::serve_repair::{RepairProtocol, RepairRequestHeader, ServeRepair},
@@ -830,6 +829,7 @@ pub mod test {
         solana_quic_client::{QuicConfig, QuicConnectionManager, QuicPool},
         solana_rpc::rpc::JsonRpcConfig,
         solana_sdk::timing::timestamp,
+        solana_tpu_client::tpu_client::TpuClientConfig,
     };
 
     const TEST_SEND_BATCH_SIZE: usize = 1;
diff --git a/gossip/src/legacy_contact_info.rs b/gossip/src/legacy_contact_info.rs
index 882df75864e357..870f1c9aa49283 100644
--- a/gossip/src/legacy_contact_info.rs
+++ b/gossip/src/legacy_contact_info.rs
@@ -327,24 +327,6 @@ mod tests {
         assert!(ci.serve_repair.ip().is_unspecified());
     }
 
-    #[test]
-    fn test_valid_client_facing() {
-        let mut ci = LegacyContactInfo::default();
-        assert_eq!(
-            ci.valid_client_facing_addr(Protocol::QUIC, &SocketAddrSpace::Unspecified),
-            None
-        );
-        ci.tpu = socketaddr!(Ipv4Addr::LOCALHOST, 123);
-        assert_eq!(
-            ci.valid_client_facing_addr(Protocol::QUIC, &SocketAddrSpace::Unspecified),
-            None
-        );
-        ci.rpc = socketaddr!(Ipv4Addr::LOCALHOST, 234);
-        assert!(ci
-            .valid_client_facing_addr(Protocol::QUIC, &SocketAddrSpace::Unspecified)
-            .is_some());
-    }
-
     #[test]
     fn test_sanitize() {
         let mut ci = LegacyContactInfo::default();
diff --git a/programs/sbf/Cargo.lock b/programs/sbf/Cargo.lock
index c634256de5cda2..d148f0bea7b5d0 100644
--- a/programs/sbf/Cargo.lock
+++ b/programs/sbf/Cargo.lock
@@ -5179,7 +5179,6 @@ dependencies = [
  "solana-metrics",
  "solana-net-utils",
  "solana-perf",
- "solana-quic-client",
  "solana-rayon-threadlimit",
  "solana-runtime",
  "solana-sdk",